Skip to content

Conversation

@vpratz
Copy link
Collaborator

@vpratz vpratz commented Aug 9, 2025

Closes #551. Here I propose to expose it via method="scipy", if you have other ideas I'd be happy about suggestions regarding the interface. I use the adapter to achieve an invertible concatenation and the conversion of the data types.

Usage example for a workflow with a continuous normalizing flow:

log_prob = workflow.log_prob(
    data, steps="adaptive", method="scipy", scipy_kwargs={"atol": 1e-6, "rtol": 1e-6}
)

@vpratz vpratz requested a review from LarsKue August 9, 2025 16:41
@codecov
Copy link

codecov bot commented Aug 9, 2025

Codecov Report

❌ Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
bayesflow/utils/integrate.py 93.75% 2 Missing ⚠️
Files with missing lines Coverage Δ
bayesflow/utils/integrate.py 52.15% <93.75%> (+8.08%) ⬆️

Copy link
Contributor

@LarsKue LarsKue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vpratz
Copy link
Collaborator Author

vpratz commented Aug 9, 2025

Thanks for the quick review :)

@vpratz vpratz merged commit 7cabf17 into dev Aug 9, 2025
9 checks passed
@vpratz vpratz deleted the feat-integrate-scipy branch August 9, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants